[PermissionService] Remove IsCurrentUserAuthorized redundancies#3838
[PermissionService] Remove IsCurrentUserAuthorized redundancies#3838imnasnainaec merged 5 commits intomasterfrom
Conversation
imnasnainaec
added
backend
maintenance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3838 +/- ##
==========================================
+ Coverage 65.87% 73.20% +7.33%
==========================================
Files 235 286 +51
Lines 6033 10751 +4718
Branches 753 1341 +588
==========================================
+ Hits 3974 7870 +3896
- Misses 1815 2483 +668
- Partials 244 398 +154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { | ||
| var currentUserId = GetUserId(request); | ||
| return userId == currentUserId; | ||
| return userId == GetUserId(request); |
There was a problem hiding this comment.
As this is right now if both of these strings were empty this would return true. Not sure why that would be the case but it would probably be a bug or error and this should return false in that case.
hahn-kev
left a comment
hahn-kev
left a comment
There was a problem hiding this comment.
the changes look good to me, I'm concerned with some of the ways security is being handled right now but that's not in scope of this PR as you're not really changing anything.
@hahn-kev Do tell me more. I'd be glad to improve the security in another pr. |
imnasnainaec
left a comment
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @hahn-kev and @imnasnainaec)
| { | ||
| var currentUserId = GetUserId(request); | ||
| return userId == currentUserId; | ||
| return userId == GetUserId(request); |
2 participants
This change is