Skip to content

[InviteController] Add ProducesResponseType attributes, one test#3843

Merged
imnasnainaec merged 4 commits intomasterfrom
invite-controller
Jun 5, 2025
Merged

[InviteController] Add ProducesResponseType attributes, one test#3843
imnasnainaec merged 4 commits intomasterfrom
invite-controller

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 4, 2025

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 4, 2025
@imnasnainaec imnasnainaec added backend test maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project labels Jun 4, 2025
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.87%. Comparing base (954de79) to head (74d7f4a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3843      +/-   ##
==========================================
- Coverage   73.20%   65.87%   -7.34%     
==========================================
  Files         286      235      -51     
  Lines       10751     6033    -4718     
  Branches     1341      753     -588     
==========================================
- Hits         7870     3974    -3896     
+ Misses       2483     1815     -668     
+ Partials      398      244     -154     
Flag Coverage Δ
backend ?
frontend 65.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Comment on lines 153 to 154
_userRepo.Create(new() { Id = "other-user" });
_userRepo.Create(new() { Id = "invitee", Email = EmailExpired });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me how these created users are part of this text 🤔.

@imnasnainaec imnasnainaec merged commit 110c283 into master Jun 5, 2025
15 of 20 checks passed
@imnasnainaec imnasnainaec deleted the invite-controller branch June 5, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants