Skip to content

[ProjectController] Update return types, Remove DeleteAllProjects#3848

Merged
imnasnainaec merged 3 commits intomasterfrom
proj-controller
Jun 12, 2025
Merged

[ProjectController] Update return types, Remove DeleteAllProjects#3848
imnasnainaec merged 3 commits intomasterfrom
proj-controller

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 5, 2025

  • Adds all missing ProducesResponseType attributes on controller functions
  • Removes response object/body from functions with a Status304NotModified response, because it's invalid and we weren't using them
  • Removes DeleteAllProjects because we'd never want to do that via a command from the frontend
  • Adds tests

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 5, 2025
@imnasnainaec imnasnainaec added backend test maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project labels Jun 5, 2025
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.65%. Comparing base (79489c0) to head (0d6403b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
Backend/Controllers/ProjectController.cs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3848      +/-   ##
==========================================
+ Coverage   66.05%   74.65%   +8.60%     
==========================================
  Files         236      287      +51     
  Lines        6057    10776    +4719     
  Branches      758     1347     +589     
==========================================
+ Hits         4001     8045    +4044     
- Misses       1809     2343     +534     
- Partials      247      388     +141     
Flag Coverage Δ
backend 85.69% <75.00%> (?)
frontend 66.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) June 12, 2025 18:33
@imnasnainaec imnasnainaec disabled auto-merge June 12, 2025 21:01
@imnasnainaec imnasnainaec merged commit c5cbf4f into master Jun 12, 2025
17 of 18 checks passed
@imnasnainaec imnasnainaec deleted the proj-controller branch June 12, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants