Skip to content

[LiftController] Add ProducesResponseType attributes#3849

Merged
imnasnainaec merged 3 commits intomasterfrom
lift-controller
Jun 12, 2025
Merged

[LiftController] Add ProducesResponseType attributes#3849
imnasnainaec merged 3 commits intomasterfrom
lift-controller

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 6, 2025

Also, make NotFound objects more explicit.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 6, 2025
@imnasnainaec imnasnainaec added backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. import/export labels Jun 6, 2025
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.69%. Comparing base (0881512) to head (9f57cf9).

Files with missing lines Patch % Lines
Backend/Controllers/LiftController.cs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3849      +/-   ##
==========================================
- Coverage   73.69%   73.69%   -0.01%     
==========================================
  Files         287      287              
  Lines       10773    10772       -1     
  Branches     1344     1344              
==========================================
- Hits         7939     7938       -1     
  Misses       2437     2437              
  Partials      397      397              
Flag Coverage Δ
backend 83.52% <60.00%> (-0.01%) ⬇️
frontend 66.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) June 12, 2025 18:30
@imnasnainaec imnasnainaec disabled auto-merge June 12, 2025 20:51
@imnasnainaec imnasnainaec merged commit 79489c0 into master Jun 12, 2025
21 of 33 checks passed
@imnasnainaec imnasnainaec deleted the lift-controller branch June 12, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend import/export maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants