Skip to content

[StatisticsController] Drop unneeded project checks#3852

Merged
imnasnainaec merged 3 commits intomasterfrom
stats-controller
Jun 17, 2025
Merged

[StatisticsController] Drop unneeded project checks#3852
imnasnainaec merged 3 commits intomasterfrom
stats-controller

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 6, 2025

A project permission check is sufficient if the project object is not needed.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 6, 2025
@imnasnainaec imnasnainaec added backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project labels Jun 6, 2025
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.82%. Comparing base (292debc) to head (9f07a78).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3852      +/-   ##
==========================================
- Coverage   74.30%   65.82%   -8.49%     
==========================================
  Files         287      236      -51     
  Lines       10669     6066    -4603     
  Branches     1331      761     -570     
==========================================
- Hits         7928     3993    -3935     
+ Misses       2355     1825     -530     
+ Partials      386      248     -138     
Flag Coverage Δ
backend ?
frontend 65.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec changed the title [StatisticsController] Drop unnecessary project checks [StatisticsController] Drop unnecessary project checks, lang param Jun 6, 2025
@imnasnainaec imnasnainaec changed the title [StatisticsController] Drop unnecessary project checks, lang param [StatisticsController] Drop unneeded project checks, lang param Jun 6, 2025
@imnasnainaec imnasnainaec changed the title [StatisticsController] Drop unneeded project checks, lang param [StatisticsController] Drop unneeded project checks Jun 6, 2025
@imnasnainaec imnasnainaec added the lowpriority This issue might not be worked on label Jun 17, 2025
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) June 17, 2025 18:35
@imnasnainaec imnasnainaec disabled auto-merge June 17, 2025 19:37
@imnasnainaec imnasnainaec merged commit 55a1e90 into master Jun 17, 2025
30 of 36 checks passed
@imnasnainaec imnasnainaec deleted the stats-controller branch June 18, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend lowpriority This issue might not be worked on maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants