[StatisticsController] Drop unneeded project checks#3852
Merged
imnasnainaec merged 3 commits intomasterfrom Jun 17, 2025
Merged
[StatisticsController] Drop unneeded project checks#3852imnasnainaec merged 3 commits intomasterfrom
imnasnainaec merged 3 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3852 +/- ##
==========================================
- Coverage 74.30% 65.82% -8.49%
==========================================
Files 287 236 -51
Lines 10669 6066 -4603
Branches 1331 761 -570
==========================================
- Hits 7928 3993 -3935
+ Misses 2355 1825 -530
+ Partials 386 248 -138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonleenaylor
approved these changes
Jun 17, 2025
Contributor
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A project permission check is sufficient if the project object is not needed.
This change is