Skip to content

[Statistics] Remove unused param from GetSemanticDomainUserCounts#3853

Merged
imnasnainaec merged 4 commits intomasterfrom
stats-nix-lang
Jun 16, 2025
Merged

[Statistics] Remove unused param from GetSemanticDomainUserCounts#3853
imnasnainaec merged 4 commits intomasterfrom
stats-nix-lang

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 6, 2025

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 6, 2025
@imnasnainaec imnasnainaec added backend frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Jun 6, 2025
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (15b0b4c) to head (9f6743c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3853   +/-   ##
=======================================
  Coverage   74.53%   74.53%           
=======================================
  Files         287      287           
  Lines       10670    10670           
  Branches     1326     1326           
=======================================
  Hits         7953     7953           
  Misses       2334     2334           
  Partials      383      383           
Flag Coverage Δ
backend 85.65% <ø> (ø)
frontend 66.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) June 16, 2025 17:33
@imnasnainaec imnasnainaec disabled auto-merge June 16, 2025 17:42
@imnasnainaec imnasnainaec merged commit 3ee21e8 into master Jun 16, 2025
19 of 21 checks passed
@imnasnainaec imnasnainaec deleted the stats-nix-lang branch June 16, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants