Skip to content

Tighten security on user info#3868

Merged
imnasnainaec merged 3 commits intomasterfrom
get-all-users
Jun 10, 2025
Merged

Tighten security on user info#3868
imnasnainaec merged 3 commits intomasterfrom
get-all-users

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 10, 2025

Absorbs #3864


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

❌ Patch coverage is 44.64286% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.58%. Comparing base (16bfcc0) to head (5759176).
⚠️ Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
Backend/Models/User.cs 0.00% 12 Missing ⚠️
Backend/Controllers/UserController.cs 11.11% 7 Missing and 1 partial ⚠️
Backend/Controllers/ProjectController.cs 0.00% 3 Missing ⚠️
src/components/ProjectUsers/ActiveProjectUsers.tsx 25.00% 3 Missing ⚠️
src/components/ProjectUsers/AddProjectUsers.tsx 0.00% 2 Missing ⚠️
src/components/ProjectUsers/SortOptions.tsx 0.00% 2 Missing ⚠️
src/components/ProjectUsers/UserList.tsx 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3868      +/-   ##
==========================================
- Coverage   73.72%   73.58%   -0.14%     
==========================================
  Files         287      287              
  Lines       10773    10789      +16     
  Branches     1344     1345       +1     
==========================================
- Hits         7942     7939       -3     
- Misses       2434     2453      +19     
  Partials      397      397              
Flag Coverage Δ
backend 83.16% <4.16%> (-0.37%) ⬇️
frontend 66.09% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 24 of 25 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit f0fafac into master Jun 10, 2025
20 of 21 checks passed
@imnasnainaec imnasnainaec deleted the get-all-users branch June 10, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants