Skip to content

[UserMenu, SiteSettings] Fix errors when coming from Project Settings#3870

Merged
imnasnainaec merged 2 commits intomasterfrom
proj-to-site-settings
Jun 11, 2025
Merged

[UserMenu, SiteSettings] Fix errors when coming from Project Settings#3870
imnasnainaec merged 2 commits intomasterfrom
proj-to-site-settings

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 11, 2025

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 11, 2025
@imnasnainaec imnasnainaec added bug Something isn't working frontend labels Jun 11, 2025
@imnasnainaec imnasnainaec requested a review from andracc June 11, 2025 12:52
@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.56%. Comparing base (91c7f22) to head (8d2339c).
⚠️ Report is 22 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3870   +/-   ##
=======================================
  Coverage   73.55%   73.56%           
=======================================
  Files         287      287           
  Lines       10791    10791           
  Branches     1347     1347           
=======================================
+ Hits         7937     7938    +1     
+ Misses       2455     2454    -1     
  Partials      399      399           
Flag Coverage Δ
backend 83.16% <ø> (ø)
frontend 66.05% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit bfd7907 into master Jun 11, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the proj-to-site-settings branch June 11, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants