Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3877 +/- ##
==========================================
+ Coverage 73.76% 73.87% +0.11%
==========================================
Files 290 294 +4
Lines 10563 10662 +99
Branches 1328 1342 +14
==========================================
+ Hits 7792 7877 +85
- Misses 2387 2398 +11
- Partials 384 387 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hahn-kev
left a comment
There was a problem hiding this comment.
There's a security issue in this one which should be fixed before merging.
On a lighter note, have you thought about what will happen to existing users who don't have a verified email? You might want to map IsEmailVerified to bool? then if you want you can have some special consideration for pre existing users where IsEmailVerified is null.
Lastly, the linked issue mentions that a user who hasn't verified their email shouldn't be able to create a project, is that being handled here? or is that out of scope of this PR.
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed 13 of 46 files at r2.
Reviewable status: 13 of 51 files reviewed, 2 unresolved discussions
Fixed.
Pre-existing users should have to verify too.
Linked issue updated. Project creation shouldn't require email verification. We want a low bar for people to experiment with The Combine. |
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 2 of 35 files at r1, 26 of 46 files at r2, 1 of 5 files at r3, 24 of 29 files at r4, 5 of 6 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @imnasnainaec)
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 11 of 29 files at r4, all commit messages.
@imnasnainaec dismissed @hahn-kev from 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #3615
Requesting email verification from Project Settings > Users




Requesting email verification from User Settings



Following link from verification email...
...once:

...again:

Settings for verified users...
Project Settings > Users:

User Settings:

This change is