Skip to content

Add email verification#3877

Merged
imnasnainaec merged 30 commits intomasterfrom
email-verify
Sep 3, 2025
Merged

Add email verification#3877
imnasnainaec merged 30 commits intomasterfrom
email-verify

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 13, 2025

Resolves #3615


Requesting email verification from Project Settings > Users
Screenshot 2025-08-19 154835
Screenshot 2025-08-19 154903
Screenshot 2025-08-19 154918
Screenshot 2025-08-19 154934


Requesting email verification from User Settings
Screenshot 2025-08-19 155009
Screenshot 2025-08-19 154918
Screenshot 2025-08-19 155037


Following link from verification email...

...once:
Screenshot 2025-08-19 155103

...again:
Screenshot 2025-08-19 155121


Settings for verified users...

Project Settings > Users:
Screenshot 2025-08-19 155723

User Settings:
Screenshot 2025-08-19 155148


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

❌ Patch coverage is 87.93103% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.87%. Comparing base (6b1646b) to head (db658e7).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/components/ProjectUsers/AddProjectUsers.tsx 40.00% 11 Missing and 1 partial ⚠️
src/components/Login/Redux/LoginActions.ts 81.81% 1 Missing and 1 partial ⚠️
src/components/Login/Redux/LoginReducer.ts 0.00% 2 Missing ⚠️
src/components/Login/Signup.tsx 0.00% 1 Missing and 1 partial ⚠️
src/components/UserSettings/UserSettings.tsx 87.50% 2 Missing ⚠️
src/components/EmailVerify/index.tsx 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3877      +/-   ##
==========================================
+ Coverage   73.76%   73.87%   +0.11%     
==========================================
  Files         290      294       +4     
  Lines       10563    10662      +99     
  Branches     1328     1342      +14     
==========================================
+ Hits         7792     7877      +85     
- Misses       2387     2398      +11     
- Partials      384      387       +3     
Flag Coverage Δ
backend 85.49% <100.00%> (+0.09%) ⬆️
frontend 65.23% <76.13%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a security issue in this one which should be fixed before merging.

On a lighter note, have you thought about what will happen to existing users who don't have a verified email? You might want to map IsEmailVerified to bool? then if you want you can have some special consideration for pre existing users where IsEmailVerified is null.

Lastly, the linked issue mentions that a user who hasn't verified their email shouldn't be able to create a project, is that being handled here? or is that out of scope of this PR.

@imnasnainaec imnasnainaec marked this pull request as draft June 17, 2025 13:09
@imnasnainaec imnasnainaec marked this pull request as draft June 17, 2025 13:09
@imnasnainaec imnasnainaec added wip Work In Progress labels Jun 17, 2025
Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 46 files at r2.
Reviewable status: 13 of 51 files reviewed, 2 unresolved discussions

@imnasnainaec imnasnainaec marked this pull request as ready for review August 20, 2025 19:53
@imnasnainaec imnasnainaec removed the wip Work In Progress label Sep 2, 2025
@imnasnainaec
Copy link
Collaborator Author

@hahn-kev

There's a security issue in this one which should be fixed before merging.

Fixed.

On a lighter note, have you thought about what will happen to existing users who don't have a verified email? You might want to map IsEmailVerified to bool? then if you want you can have some special consideration for pre existing users where IsEmailVerified is null.

Pre-existing users should have to verify too.

Lastly, the linked issue mentions that a user who hasn't verified their email shouldn't be able to create a project, is that being handled here? or is that out of scope of this PR.

Linked issue updated. Project creation shouldn't require email verification. We want a low bar for people to experiment with The Combine.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 2 of 35 files at r1, 26 of 46 files at r2, 1 of 5 files at r3, 24 of 29 files at r4, 5 of 6 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @imnasnainaec)

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed 11 of 29 files at r4, all commit messages.
@imnasnainaec dismissed @hahn-kev from 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit ff3185a into master Sep 3, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the email-verify branch September 3, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For online settings, require email verification for project creation

3 participants