[CharInv] Clean up Completed component without deprecated Grid#3878
Merged
imnasnainaec merged 2 commits intomasterfrom Jun 16, 2025
Merged
[CharInv] Clean up Completed component without deprecated Grid#3878imnasnainaec merged 2 commits intomasterfrom
imnasnainaec merged 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3878 +/- ##
==========================================
+ Coverage 66.05% 74.53% +8.48%
==========================================
Files 236 287 +51
Lines 6057 10670 +4613
Branches 758 1326 +568
==========================================
+ Hits 4001 7953 +3952
- Misses 1809 2334 +525
- Partials 247 383 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
imnasnainaec
force-pushed
the
char-inv-completed
branch
from
f1174c0 to
d33b003
Compare
imnasnainaec
force-pushed
the
char-inv-completed
branch
from
d33b003 to
bbfd1b9
Compare
jasonleenaylor
approved these changes
Jun 16, 2025
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3787
Prereq for #3836
This change is