[WordCard, goals] Migrate from deprecated Grid#3879
Closed
imnasnainaec wants to merge 4 commits intomasterfrom
Closed
[WordCard, goals] Migrate from deprecated Grid#3879imnasnainaec wants to merge 4 commits intomasterfrom
imnasnainaec wants to merge 4 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3879 +/- ##
==========================================
- Coverage 74.53% 65.99% -8.55%
==========================================
Files 287 236 -51
Lines 10670 6060 -4610
Branches 1326 762 -564
==========================================
- Hits 7953 3999 -3954
+ Misses 2334 1813 -521
+ Partials 383 248 -135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jun 17, 2025
This was referenced Aug 11, 2025
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3787
Notes for review:
<Grid>with<Grid2>,<Stack>,<Box>,<div>, or nothing, as fit the design need.<Stack direction="row">can be used in place of<Grid2>when we don't want the items in the row to wrap to a second row in a narrow windowCharInvinto child componentCharacterEntryat topmaster(on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited components*Completedcomponents by clicking a completed goal tile in Data Cleanup under "You've completed:"MergeDupsCompleted, first go to Data Cleanup > Merge Duplicates, and merge and/or delete words in various combinationsWordCardandReviewEntriesCompleted, first go to Data Cleanup > Review Entries and edit several entries, including adding multiple semantic domains to a senseThis change is