Skip to content

[WordCard, goals] Migrate from deprecated Grid#3879

Closed
imnasnainaec wants to merge 4 commits intomasterfrom
grid2e-goals
Closed

[WordCard, goals] Migrate from deprecated Grid#3879
imnasnainaec wants to merge 4 commits intomasterfrom
grid2e-goals

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 16, 2025

Part of #3787

Notes for review:

  • In most places, replaced <Grid> with <Grid2>, <Stack>, <Box>, <div>, or nothing, as fit the design need.
  • <Stack direction="row"> can be used in place of <Grid2> when we don't want the items in the row to wrap to a second row in a narrow window
  • Moved Save and Cancel buttons from bottom of CharInv into child component CharacterEntry at top
  • Do a side-by-side visual comparison between this and master (on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited components
  • Try each edited component with various window widths > 350px (we don't support narrower than that)
  • Test *Completed components by clicking a completed goal tile in Data Cleanup under "You've completed:"
    • For MergeDupsCompleted, first go to Data Cleanup > Merge Duplicates, and merge and/or delete words in various combinations
    • For WordCard and ReviewEntriesCompleted, first go to Data Cleanup > Review Entries and edit several entries, including adding multiple semantic domains to a sense
  • Test with a few different UI languages

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 16, 2025
@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. goal: MergeDup goal: ReviewEntries labels Jun 16, 2025
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

❌ Patch coverage is 56.89655% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.99%. Comparing base (15b0b4c) to head (678602d).
⚠️ Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
...oals/CharacterInventory/CharInv/CharacterEntry.tsx 77.77% 4 Missing ⚠️
...riesTable/Cells/EditCell/EditSensesCardContent.tsx 33.33% 4 Missing ⚠️
src/components/Buttons/UndoButton.tsx 25.00% 3 Missing ⚠️
...CharacterInventory/CharInv/CharacterList/index.tsx 50.00% 2 Missing ⚠️
src/goals/MergeDuplicates/MergeDupsCompleted.tsx 60.00% 2 Missing ⚠️
...geDuplicates/MergeDupsStep/MergeDragDrop/index.tsx 50.00% 2 Missing ⚠️
src/goals/ReviewEntries/ReviewEntriesCompleted.tsx 0.00% 2 Missing ⚠️
...s/ReviewEntriesTable/Cells/EditCell/EditDialog.tsx 60.00% 2 Missing ⚠️
...iewEntriesTable/Cells/EditCell/EditSenseDialog.tsx 0.00% 2 Missing ⚠️
src/goals/CharacterInventory/CharInv/index.tsx 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3879      +/-   ##
==========================================
- Coverage   74.53%   65.99%   -8.55%     
==========================================
  Files         287      236      -51     
  Lines       10670     6060    -4610     
  Branches     1326      762     -564     
==========================================
- Hits         7953     3999    -3954     
+ Misses       2334     1813     -521     
+ Partials      383      248     -135     
Flag Coverage Δ
backend ?
frontend 65.99% <56.89%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec changed the title [WordCard, MergeDups, ReviewEntries] Migrate from deprecated Grid [WordCard, goals] Migrate from deprecated Grid Jun 16, 2025
@imnasnainaec
Copy link
Collaborator Author

Split into #3883 #3885 #3925 #3930

@imnasnainaec imnasnainaec deleted the grid2e-goals branch August 13, 2025 13:39
@imnasnainaec imnasnainaec added duplicate This issue or pull request already exists and removed wip Work In Progress labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists frontend goal: CharacterInventory goal: MergeDup goal: ReviewEntries goal maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant