Skip to content

[ReviewEntries] Migrate from deprecations#3883

Merged
imnasnainaec merged 22 commits intomasterfrom
rev-entries-completed
Aug 19, 2025
Merged

[ReviewEntries] Migrate from deprecations#3883
imnasnainaec merged 22 commits intomasterfrom
rev-entries-completed

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 17, 2025

Parts of #3180, #3879

Notes for review:

  • In most places, replaced <Grid> with <Grid2>, <Stack>, <Box>, <div>, or nothing, as fit the design need.
  • <Stack direction="row"> can be used in place of <Grid2> when we don't want the items in the row to wrap to a second row in a narrow window

Notes for testing:

  • Do a side-by-side visual comparison between this and master (on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited components
  • Try each edited component with various window widths > 350px (we don't support narrower than that)
  • Test with a few different UI languages

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 17, 2025
@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. goal: ReviewEntries labels Jun 17, 2025
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

❌ Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.79%. Comparing base (72d059f) to head (7729988).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...riesTable/Cells/EditCell/EditSensesCardContent.tsx 50.00% 3 Missing ⚠️
...s/ReviewEntriesTable/Cells/EditCell/EditDialog.tsx 60.00% 2 Missing ⚠️
...iewEntriesTable/Cells/EditCell/EditSenseDialog.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3883      +/-   ##
==========================================
- Coverage   73.85%   73.79%   -0.07%     
==========================================
  Files         289      289              
  Lines       10565    10561       -4     
  Branches     1326     1326              
==========================================
- Hits         7803     7793      -10     
- Misses       2376     2384       +8     
+ Partials      386      384       -2     
Flag Coverage Δ
backend 85.41% <ø> (ø)
frontend 65.08% <56.25%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec changed the title [WordCard, ReviewEntriesCompleted] Migrate from deprecated Grid [WordCard, ReviewEntries] Migrate from deprecations Jun 17, 2025
@imnasnainaec imnasnainaec marked this pull request as draft August 11, 2025 18:42
@imnasnainaec imnasnainaec changed the title [WordCard, ReviewEntries] Migrate from deprecations [ReviewEntries] Migrate from deprecations Aug 11, 2025
@github-actions github-actions bot added the test label Aug 13, 2025
@github-actions github-actions bot added the goal label Aug 15, 2025
@imnasnainaec imnasnainaec marked this pull request as ready for review August 15, 2025 13:48
@imnasnainaec imnasnainaec force-pushed the rev-entries-completed branch from 15bad39 to 43d78f5 Compare August 18, 2025 15:19
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 8 files at r2, 1 of 7 files at r3, 6 of 10 files at r4, 8 of 8 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/goals/ReviewEntries/ReviewEntriesTable/tests/index.test.tsx line 86 at r5 (raw file):

    await renderReviewEntriesTable();
    expect(mockGetFrontierWords).toHaveBeenCalled();
    const rowCount = mockWords().length + 1; // +1 for header row

Nice improvement.


src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/tests/EditSenseDialog.test.tsx line 139 at r5 (raw file):

      await renderEditSenseDialog(false, true);
      expect(screen.queryByText(definitionsTitle)).toBeNull();
      expect(screen.queryByText(partOfSpeechTitle)).toBeTruthy();

Technically this is less restrictive than before...


src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/tests/EditDialog.test.tsx line 23 at r5 (raw file):

  "goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/EditSensesCardContent",
  () => ({
    __esModule: true,

Fancy.

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/tests/EditSenseDialog.test.tsx line 139 at r5 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Technically this is less restrictive than before...

It will throw if the count is >1. queryAllBy... would be less restrictive.

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 19, 2025 19:47
@imnasnainaec imnasnainaec merged commit a48254b into master Aug 19, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the rev-entries-completed branch August 19, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend goal: ReviewEntries maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants