[ReviewEntries] Migrate from deprecations#3883
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3883 +/- ##
==========================================
- Coverage 73.85% 73.79% -0.07%
==========================================
Files 289 289
Lines 10565 10561 -4
Branches 1326 1326
==========================================
- Hits 7803 7793 -10
- Misses 2376 2384 +8
+ Partials 386 384 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8b231b5 to
5ea9cab
Compare
15bad39 to
43d78f5
Compare
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 2 of 8 files at r2, 1 of 7 files at r3, 6 of 10 files at r4, 8 of 8 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/goals/ReviewEntries/ReviewEntriesTable/tests/index.test.tsx line 86 at r5 (raw file):
await renderReviewEntriesTable(); expect(mockGetFrontierWords).toHaveBeenCalled(); const rowCount = mockWords().length + 1; // +1 for header row
Nice improvement.
src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/tests/EditSenseDialog.test.tsx line 139 at r5 (raw file):
await renderEditSenseDialog(false, true); expect(screen.queryByText(definitionsTitle)).toBeNull(); expect(screen.queryByText(partOfSpeechTitle)).toBeTruthy();
Technically this is less restrictive than before...
src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/tests/EditDialog.test.tsx line 23 at r5 (raw file):
"goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/EditSensesCardContent", () => ({ __esModule: true,
Fancy.
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/tests/EditSenseDialog.test.tsx line 139 at r5 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Technically this is less restrictive than before...
It will throw if the count is >1. queryAllBy... would be less restrictive.
Parts of #3180, #3879
Notes for review:
<Grid>with<Grid2>,<Stack>,<Box>,<div>, or nothing, as fit the design need.<Stack direction="row">can be used in place of<Grid2>when we don't want the items in the row to wrap to a second row in a narrow windowNotes for testing:
master(on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited componentsThis change is