Skip to content

Implement getLocalizedDateTimeString; Add onlyId to DomainChip#3933

Merged
imnasnainaec merged 3 commits intomasterfrom
date-time-string
Aug 19, 2025
Merged

Implement getLocalizedDateTimeString; Add onlyId to DomainChip#3933
imnasnainaec merged 3 commits intomasterfrom
date-time-string

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 15, 2025

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.78%. Comparing base (a48254b) to head (a3a7b5d).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/utilities/utilities.ts 0.00% 2 Missing ⚠️
src/components/WordCard/DomainChip.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3933      +/-   ##
==========================================
- Coverage   73.79%   73.78%   -0.01%     
==========================================
  Files         289      289              
  Lines       10561    10565       +4     
  Branches     1326     1328       +2     
==========================================
+ Hits         7793     7795       +2     
- Misses       2384     2386       +2     
  Partials      384      384              
Flag Coverage Δ
backend 85.41% <ø> (ø)
frontend 65.07% <76.92%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

imnasnainaec added a commit that referenced this pull request Aug 15, 2025
imnasnainaec added a commit that referenced this pull request Aug 15, 2025
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/components/WordCard/DomainChip.tsx line 15 at r2 (raw file):

interface DomainChipProps {
  domain: SemanticDomain;
  onlyId?: boolean;

This part of the change isn't mentioned in the commit comments, you can slip it in if you intended to but make sure the commit speaks to it.

@imnasnainaec imnasnainaec changed the title Implement getLocalizedDateTimeString util function Implement getLocalizedDateTimeString; Add onlyId to DomainChip Aug 19, 2025
@imnasnainaec imnasnainaec enabled auto-merge (squash) August 19, 2025 20:01
@imnasnainaec imnasnainaec merged commit 3078992 into master Aug 19, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the date-time-string branch August 19, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants