Implement getLocalizedDateTimeString; Add onlyId to DomainChip#3933
Implement getLocalizedDateTimeString; Add onlyId to DomainChip#3933imnasnainaec merged 3 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3933 +/- ##
==========================================
- Coverage 73.79% 73.78% -0.01%
==========================================
Files 289 289
Lines 10561 10565 +4
Branches 1326 1328 +2
==========================================
+ Hits 7793 7795 +2
- Misses 2384 2386 +2
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ff2da29 to
7ba36fb
Compare
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/components/WordCard/DomainChip.tsx line 15 at r2 (raw file):
interface DomainChipProps { domain: SemanticDomain; onlyId?: boolean;
This part of the change isn't mentioned in the commit comments, you can slip it in if you intended to but make sure the commit speaks to it.
This change is