Skip to content

Remove component from Redux testing#3881

Merged
imnasnainaec merged 2 commits intomasterfrom
goal-redux-test
Jun 17, 2025
Merged

Remove component from Redux testing#3881
imnasnainaec merged 2 commits intomasterfrom
goal-redux-test

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 16, 2025

Also fix i18n import for Captcha to make testing easier.

Prereq for #3836


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 16, 2025
@imnasnainaec imnasnainaec changed the title Remove component from redux testing Remove component from Redux testing Jun 16, 2025
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.30%. Comparing base (274ed14) to head (e6f0338).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Login/Captcha.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3881      +/-   ##
==========================================
- Coverage   74.41%   74.30%   -0.11%     
==========================================
  Files         287      287              
  Lines       10669    10669              
  Branches     1331     1331              
==========================================
- Hits         7939     7928      -11     
- Misses       2344     2355      +11     
  Partials      386      386              
Flag Coverage Δ
backend 85.48% <ø> (ø)
frontend 65.82% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) June 17, 2025 18:28
@imnasnainaec imnasnainaec merged commit 292debc into master Jun 17, 2025
22 of 24 checks passed
@imnasnainaec imnasnainaec deleted the goal-redux-test branch June 17, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants