Skip to content

[CharInv] Have find-replace auto-save would-be-lost changes#3937

Merged
imnasnainaec merged 1 commit intomasterfrom
bugfix/char-inv-save-find-replace
Aug 18, 2025
Merged

[CharInv] Have find-replace auto-save would-be-lost changes#3937
imnasnainaec merged 1 commit intomasterfrom
bugfix/char-inv-save-find-replace

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 18, 2025

Fixes #3884 (with solution option 1).

Also, closes the defunct character detail panel for the found-and-replaced character.


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.91%. Comparing base (620aff8) to head (5932ea7).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...racterInventory/Redux/CharacterInventoryActions.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3937      +/-   ##
==========================================
- Coverage   73.96%   73.91%   -0.05%     
==========================================
  Files         289      289              
  Lines       10562    10567       +5     
  Branches     1326     1326              
==========================================
- Hits         7812     7811       -1     
- Misses       2364     2370       +6     
  Partials      386      386              
Flag Coverage Δ
backend 85.41% <ø> (ø)
frontend 65.31% <57.14%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit c263518 into master Aug 18, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/char-inv-save-find-replace branch August 18, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CharInv] Using find-and-replace resets any unsaved inventory changes

2 participants