Skip to content

Stop using loadable with Buttons, Dialogs#3940

Merged
imnasnainaec merged 1 commit intomasterfrom
buttons-dialogs
Sep 8, 2025
Merged

Stop using loadable with Buttons, Dialogs#3940
imnasnainaec merged 1 commit intomasterfrom
buttons-dialogs

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Sep 8, 2025

Resolves #3803


This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.81%. Comparing base (ff3185a) to head (2cf945e).
⚠️ Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3940      +/-   ##
==========================================
- Coverage   73.87%   73.81%   -0.06%     
==========================================
  Files         294      292       -2     
  Lines       10662    10630      -32     
  Branches     1342     1342              
==========================================
- Hits         7877     7847      -30     
+ Misses       2398     2396       -2     
  Partials      387      387              
Flag Coverage Δ
backend 85.49% <ø> (ø)
frontend 65.08% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 68 of 68 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit d4f2468 into master Sep 8, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the buttons-dialogs branch September 8, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Buttons, Dialogs

2 participants