Replace InputLabelProps, InputProps, inputProps with slotProps#3941
Replace InputLabelProps, InputProps, inputProps with slotProps#3941imnasnainaec merged 5 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3941 +/- ##
==========================================
- Coverage 74.15% 74.08% -0.08%
==========================================
Files 292 292
Lines 10653 10653
Branches 1346 1347 +1
==========================================
- Hits 7900 7892 -8
- Misses 2369 2376 +7
- Partials 384 385 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b34a3f5 to
fe95ff2
Compare
|
So this is the default now? |
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 35 files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/goals/ReviewEntries/ReviewEntriesTable/Cells/EditCell/EditSenseDialog.tsx line 417 at r3 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
So this is the default now?
Yes, the default of the underlying MUI TextField.
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 8 of 8 files at r1, 14 of 18 files at r2, 13 of 13 files at r3.
Reviewable status: 34 of 35 files reviewed, all discussions resolved (waiting on @imnasnainaec)
Also reduce
idanddata-testidclutter.Also remove some props that were assigned the default value.
Resolves #3800
This change is