Skip to content

[EmailVerify] Logout on success to avoid cross-tab state confusion#3953

Merged
imnasnainaec merged 1 commit intomasterfrom
bugfix/email-verify-multitab
Oct 20, 2025
Merged

[EmailVerify] Logout on success to avoid cross-tab state confusion#3953
imnasnainaec merged 1 commit intomasterfrom
bugfix/email-verify-multitab

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 17, 2025

Fixes #3951


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 17, 2025
@imnasnainaec imnasnainaec added the 🟥High High-priority PR: please review this asap! label Oct 17, 2025
@imnasnainaec imnasnainaec added the bug Something isn't working label Oct 17, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.06%. Comparing base (e423df4) to head (ae7044f).
⚠️ Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Login/Redux/LoginActions.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3953      +/-   ##
==========================================
- Coverage   74.08%   74.06%   -0.02%     
==========================================
  Files         292      292              
  Lines       10653    10653              
  Branches     1347     1347              
==========================================
- Hits         7892     7890       -2     
- Misses       2376     2378       +2     
  Partials      385      385              
Flag Coverage Δ
backend 85.29% <ø> (ø)
frontend 65.64% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 4b1185f into master Oct 20, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/email-verify-multitab branch October 20, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend 🟥High High-priority PR: please review this asap! login/signUp test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Email-verified overwritten in state

2 participants

Comments