Skip to content

Tidy redux tests#3962

Merged
imnasnainaec merged 1 commit intomasterfrom
redux-test-tidy
Oct 27, 2025
Merged

Tidy redux tests#3962
imnasnainaec merged 1 commit intomasterfrom
redux-test-tidy

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 24, 2025

  • Change redux test files from .tsx to .ts
  • Update mocking to avoid an eslint-disable- comment

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.30%. Comparing base (9b4f75b) to head (12283aa).
⚠️ Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3962      +/-   ##
==========================================
- Coverage   74.30%   74.30%   -0.01%     
==========================================
  Files         292      291       -1     
  Lines       10794    10792       -2     
  Branches     1352     1352              
==========================================
- Hits         8021     8019       -2     
  Misses       2387     2387              
  Partials      386      386              
Flag Coverage Δ
backend 85.45% <ø> (ø)
frontend 65.69% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as ready for review October 27, 2025 11:54
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit e1fab57 into master Oct 27, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the redux-test-tidy branch October 27, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants