Disable vernacular field when word or sense is protected#3972
Disable vernacular field when word or sense is protected#3972imnasnainaec merged 6 commits intomasterfrom
Conversation
Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3972 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 291 291
Lines 10790 10790
Branches 1351 1351
=======================================
Hits 8028 8028
Misses 2373 2373
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
src/components/DataEntry/DataEntryTable/tests/RecentEntry.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 1 of 2 files at r2, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @copilot)
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 of 2 files at r2, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @copilot)
Summary
Updated the implementation based on code review feedback to use the simpler
accessibilityproperty instead of checking theprotectReasonsarray. The vernacular field is now disabled when either the word or sense hasaccessibility === Status.Protected. Test organization improved by moving protection tests into the vernacular describe block and removing the redundant test that checked the enabled state (already implicit in the first vernacular test).Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
This change is