Skip to content

Remove vesitigial showCertExpiration#3982

Merged
imnasnainaec merged 3 commits intomasterfrom
nix-configShowCertExpiration
Oct 31, 2025
Merged

Remove vesitigial showCertExpiration#3982
imnasnainaec merged 3 commits intomasterfrom
nix-configShowCertExpiration

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 30, 2025

Remove unused variable that's no longer needed since #377 closed.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 30, 2025
@imnasnainaec imnasnainaec added the 🟩Low Low-priority PR label Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.40%. Comparing base (1a493f1) to head (0ca3f19).
⚠️ Report is 34 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3982   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files         291      291           
  Lines       10790    10790           
  Branches     1351     1351           
=======================================
  Hits         8028     8028           
  Misses       2373     2373           
  Partials      389      389           
Flag Coverage Δ
backend 85.45% <ø> (ø)
frontend 65.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit a971f34 into master Oct 31, 2025
22 checks passed
@imnasnainaec imnasnainaec deleted the nix-configShowCertExpiration branch October 31, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants