Skip to content

Fix docker_build condition to only run on prs#3985

Merged
imnasnainaec merged 3 commits intomasterfrom
gha-workflow-if
Oct 31, 2025
Merged

Fix docker_build condition to only run on prs#3985
imnasnainaec merged 3 commits intomasterfrom
gha-workflow-if

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 31, 2025

The syntax was wrong so this line was ignored. The result is that the docker_build jobs run when prs are merged into master which is redundant with the builds for qa deployment.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 31, 2025
@imnasnainaec imnasnainaec added the 🟩Low Low-priority PR label Oct 31, 2025
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.40%. Comparing base (a971f34) to head (bfc3451).
⚠️ Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3985   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files         291      291           
  Lines       10790    10790           
  Branches     1351     1351           
=======================================
  Hits         8028     8028           
  Misses       2373     2373           
  Partials      389      389           
Flag Coverage Δ
backend 85.45% <ø> (ø)
frontend 65.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) October 31, 2025 18:19
@imnasnainaec imnasnainaec merged commit b812dde into master Oct 31, 2025
21 of 22 checks passed
@imnasnainaec imnasnainaec deleted the gha-workflow-if branch October 31, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code 🟩Low Low-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants