Skip to content

Clean up use of js/ts in scripts#4001

Merged
imnasnainaec merged 5 commits intomasterfrom
ts-js-scripts
Nov 6, 2025
Merged

Clean up use of js/ts in scripts#4001
imnasnainaec merged 5 commits intomasterfrom
ts-js-scripts

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 4, 2025

  • Update createBackendLicenses, parcelResolver from js to ts
  • Change setupMongo from ts to js to be able to use fs-extra (already in frontendScripts.js) instead of make-dir
  • Remove dependency make-dir and update frontend license report
  • Add to .gitignore a ! exception for each of the three remaining .js scripts (so they aren't automatically excluded in the VSCode search)
  • In src/react-app-env.d.ts, remove readonly from NODE_ENV to handle an error I only noticed when trying to update jestTest.js to ts

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Nov 4, 2025
@imnasnainaec imnasnainaec added the 🟩Low Low-priority PR label Nov 4, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation frontend dependencies Pull requests that update a dependency file labels Nov 4, 2025
@github-actions github-actions bot added the docker label Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.60%. Comparing base (e9bfa53) to head (abce455).
⚠️ Report is 26 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4001   +/-   ##
=======================================
  Coverage   74.60%   74.60%           
=======================================
  Files         293      293           
  Lines       10818    10818           
  Branches     1354     1354           
=======================================
  Hits         8071     8071           
  Misses       2352     2352           
  Partials      395      395           
Flag Coverage Δ
backend 85.45% <ø> (ø)
frontend 66.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit dcb46a7 into master Nov 6, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the ts-js-scripts branch November 6, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docker documentation Improvements or additions to documentation frontend 🟩Low Low-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants