Skip version check for uninstall operations

[Copilot]

The install-combine.sh script required COMBINE_VERSION to be set for all operations, including uninstall, where the version is irrelevant.

Change

Modified the version check to conditionally run based on the installation state:

# Check that we have a COMBINE_VERSION (not needed for uninstall)
if [[ "${STATE}" != "Uninstall-combine" && -z "${COMBINE_VERSION}" ]] ; then
  error "Combine version is not specified."
fi

The uninstall operation can now proceed without specifying a version, while install/update operations continue to require it.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[installer] version required for uninstall</issue_title>
<issue_description>deploy\scripts\install-combine.sh has a check:

# Check that we have a COMBINE_VERSION
if [ -z "${COMBINE_VERSION}" ] ; then
  error "Combine version is not specified."
fi

But that check isn't relevant for the uninstall case.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [installer] version required for uninstall #4114

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

---

This change is 

Summary by CodeRabbit

• Bug Fixes
  • Improved uninstallation process to no longer enforce version validation requirements, allowing the application to be removed cleanly and reliably without compatibility checks.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified the COMBINE_VERSION validation check in the install script to skip validation when uninstalling (STATE=Uninstall-combine), allowing uninstall operations to proceed without specifying a version requirement.

Changes

Cohort / File(s)	Summary
Version Check Conditional deploy/scripts/install-combine.sh	Added conditional to skip COMBINE_VERSION validation when STATE is "Uninstall-combine"; version requirement now only enforced for non-uninstall operations

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A version? Not needed to say goodbye,
The script now checks before asking why.
Uninstall flows smooth, no strings attached,
A cleaner departure—perfectly matched! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: making the version check conditional to skip it during uninstall operations.
Linked Issues check	✅ Passed	The PR directly addresses issue #4114 by making the COMBINE_VERSION check conditional, skipping it for uninstall operations as required.
Out of Scope Changes check	✅ Passed	The changes are limited to the specific requirement in issue #4114: modifying the version check condition in install-combine.sh to skip it for uninstall.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[imnasnainaec]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.92%. Comparing base (2bb9ebe) to head (bcb39c1).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4115   +/-   ##
=======================================
  Coverage   74.92%   74.92%           
=======================================
  Files         295      295           
  Lines       10911    10911           
  Branches     1366     1366           
=======================================
  Hits         8175     8175           
  Misses       2341     2341           
  Partials      395      395           

Flag	Coverage Δ
backend	86.46% <ø> (ø)
frontend	66.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.