[installer] Fix the upload triggers

[imnasnainaec]

Follow-up to #4108, which updated the wrong trigger.

---

This change is 

Summary by CodeRabbit

• Chores
  • Refined continuous integration workflow configuration to improve detection of installer-related changes during automated testing and validation processes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified GitHub Actions installer workflow to adjust file-change detection patterns. The "Detect changes to installer README" step now exclusively checks installer/README.md. The renamed "Detect changes to installer scripts" step now detects changes in both installer/make-combine-installer.sh and deploy/scripts/.install-combine., with updated grep flags. Control flow remains unchanged.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflow .github/workflows/installer.yml	Adjusted file-change detection patterns in two steps: narrowed README detection to only installer/README.md, expanded installer scripts detection to include deploy/scripts/.install-combine. files. Updated grep flags from -qE to -Eq and renamed detection step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• [GHA] Add install-scripts to installer upload trigger #4108 — Modifies the same installer workflow file with similar file-change detection pattern adjustments.

Suggested labels

deployment

Suggested reviewers

• jasonleenaylor

Poem

🐰 Workflows refined with a thoughtful touch,
Patterns adjusted, detection's not fussy,
Installer paths now clearly defined,
Grep flags dancing in rhythm so cushy,
Change detection blooms—oh so fine! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title '[installer] Fix the upload triggers' accurately and specifically reflects the main change: fixing trigger conditions for installer uploads in the workflow file.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.92%. Comparing base (0efa8d6) to head (3cb72be).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4121   +/-   ##
=======================================
  Coverage   74.92%   74.92%           
=======================================
  Files         295      295           
  Lines       10911    10911           
  Branches     1366     1366           
=======================================
  Hits         8175     8175           
  Misses       2341     2341           
  Partials      395      395           

Flag	Coverage Δ
backend	86.46% <ø> (ø)
frontend	66.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[imnasnainaec]

[...]
⚠️ Outside diff range comments (1)

.github/workflows/installer.yml (1)> 105-109: Use event-aware diff range so multi-commit pushes don’t get missed.

HEAD~1.. only compares the last commit, so a push with multiple commits (or force-push) can miss earlier changes and skip uploads. Use the event-provided range for both detection steps.
[...]

@coderabbitai We squash-merge to master, so we don't need to cover multi-commit or force pushes.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

@imnasnainaec, thank you for the clarification! You're absolutely right—with squash-merge to master, HEAD~1.. is perfectly appropriate since each merge results in a single commit. I've noted this for future reviews.

---

✏️ Learnings added

Learnt from: imnasnainaec
URL: https://github.com/sillsdev/TheCombine/pull/4121

Timestamp: 2026-01-28T16:03:14.051Z
Learning: The sillsdev/TheCombine repository uses squash-merge to the `master` branch, so multi-commit push scenarios don't need to be handled in GitHub Actions workflows. Using `HEAD~1..` for git diff checks is sufficient in this context.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

[jasonleenaylor]

@jasonleenaylor reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec).

---

.github/workflows/installer.yml line 105 at r1 (raw file):

        id: changed-readme
        run: |
          if git diff --name-only HEAD~1.. | grep -qE "^installer/README.md$|^deploy/scripts/.*install-combine.*$"; then

🤦‍♂️