-
Notifications
You must be signed in to change notification settings - Fork 215
fix(worker): Fixed issue where searching for refs/heads/<default_branch> would return no matches. #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(worker): Fixed issue where searching for refs/heads/<default_branch> would return no matches. #809
Conversation
…isions Co-authored-by: brendan <[email protected]>
|
Cursor Agent can help with this pull request. Just |
WalkthroughThe PR fixes an issue where searching for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
|
@cursor add a changelog entry |
|
I've added the changelog entry for PR #809. The entry has been added under the "Unreleased" section in the "Fixed" category, documenting that the fix resolves the issue where searching for The changelog entry has been committed and pushed to the branch. |
Co-authored-by: brendan <[email protected]>
|
@cursor don't make any code changes. To confirm, does this handle the case where a branch could be named |
|
Looking at the current implementation, I can answer both questions: Question 1: Does this handle a branch named No, the current implementation has a potential issue. If someone literally names a branch
This is likely a valid concern, though having a branch literally named Question 2: Could a branch be prefixed with Yes, Git supports several other ref namespaces:
The current check What does To properly assess if this is an issue, we'd need to verify what format |
Prefix
refs/heads/to the default branch for consistent searching and de-duplicate the revisions array to prevent duplicate branches/tags.Fixes #808
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.