sourcegraph: lsif worker can write to /tmp#342
Merged
michaellzc merged 1 commit intomainfrom Aug 31, 2023
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
michaellzc
changed the title
filiphaftek
approved these changes
Aug 31, 2023
daxmc99
approved these changes
Aug 31, 2023
Contributor
daxmc99
left a comment
daxmc99
left a comment
There was a problem hiding this comment.
LGTM
@michaellzc Do you know the default max size for emptyDir backed by files? Or what determines it?
Member
Author
by default there's no limit, up to whatever the node disk is available. i remember you can make request/limts or utilize https://kubernetes.io/docs/concepts/storage/ephemeral-volumes/#csi-ephemeral-volumes once we upgrade to k8s 1.25 |
michaellzc
added a commit
that referenced
this pull request
Aug 31, 2023
michaellzc
added a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INC-237
https://github.com/sourcegraph/sourcegraph/issues/53828
Checklist
Test plan
CI