bindings/go: Add common APIs for Range and Position#248
Merged
varungandhi-src merged 5 commits intomainfrom Jun 11, 2024
Merged
bindings/go: Add common APIs for Range and Position#248varungandhi-src merged 5 commits intomainfrom
varungandhi-src merged 5 commits intomainfrom
Conversation
Co-authored-by: Christoph Hegemann <christoph.hegemann@sourcegraph.com>
varungandhi-src
force-pushed
the
vg/range-apis
branch
from
b0b680d to
c89a34f
Compare
varungandhi-src
commented
Jun 11, 2024
kritzcreek
reviewed
Jun 11, 2024
varungandhi-src
force-pushed
the
vg/range-apis
branch
from
0648fdc to
00e067f
Compare
kritzcreek
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Range type in this package is 128-bits, whereas some Range types
in the Sourcegraph packages are 256-bits. Additionally, some of the APIs
would previously work using
*Rangeinstead of justRange.This PR fixes the pointer-based APIs and adds commonly used APIs
for Range and Position so we don't have to keep re-implementing them.
We also add documentation that ranges are half-open, not closed.
Test plan
Added new tests