This repository was archived by the owner on Sep 30, 2024. It is now read-only.
cmd/server: remove jaeger, disable opentelemetry by default#41244
Merged
cmd/server: remove jaeger, disable opentelemetry by default#41244
Conversation
13 tasks
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff af067ef...8b4ec25.
|
sanderginn
approved these changes
Sep 2, 2022
Contributor
sanderginn
left a comment
sanderginn
left a comment
There was a problem hiding this comment.
I added a blurb to stress that while this deployment ships without tracing we do in fact support it.
For the rest, LGTM
sanderginn
reviewed
Sep 2, 2022
| The Docker Single Container deployment type is a way to very quickly get an instance of Sourcegraph set up locally to experiment with many of its features. However, it is **not recommended** for a production instance, and **has limitations** depending on the OS you are deploying to, as well as the associated resources. See the [troubleshooting section](#troubleshooting) for additional information. | ||
|
|
||
| [Code Insights](../../../code_insights/index.md) is not supported in Single Container deployments. To try Code Insights you must deploy using [Docker Compose](../docker-compose/index.md) or [Kubernetes](../kubernetes/index.md). | ||
| [Code Insights](../../../code_insights/index.md) is not supported in Single Container deployments. To try Code Insights you must deploy using [Docker Compose](../docker-compose/index.md) or [Kubernetes](../kubernetes/index.md). [Tracing](../../observability/tracing.md) is disabled by default, and if you intend to enable it, you will have to deploy and configure the [OpenTelemetry Collector](../../observability/opentelemetry.md). The Single Container deployment does not ship with this service included. It is strongly recommended to use one of the aforementioned deployment methods if tracing support is a requirement. |
Contributor
There was a problem hiding this comment.
I realise this is quite the understatement of the amount of effort it would take someone to get this all to work but I don't think anyone will actually attempt it
Member
Author
There was a problem hiding this comment.
I like this, thanks for the addition!
jhchabran
approved these changes
Sep 2, 2022
efritz
pushed a commit
that referenced
this pull request
Sep 6, 2022
With jaeger no longer being the default tracing mechanism (#41242), this change removes jaeger from sourcegraph/server - it is disrecommended for production use, so I think this is probably fine - and also disables OpenTelemetry (#41243) in sourcegraph/server so we don't have to figure out an OpenTelemetry deployment for it (again, this image is not recommended for production use so I don't think we need to introduce advanced capabilities like OpenTelemetry out-of-the-box for it (there is some precedent for this - cAdvisor, for example, is not included in sourcegraph/server). Users can still configure an exporter with OTEL_EXPORTER_OTLP_ENDPOINT. Co-authored-by: Sander Ginn <sander@ginn.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
jaegerno longer being the default tracing mechanism (https://github.com/sourcegraph/sourcegraph/pull/41242), this change removesjaegerfromsourcegraph/server- it is disrecommended for production use, so I think this is probably fine - and also disables OpenTelemetry (https://github.com/sourcegraph/sourcegraph/pull/41243) insourcegraph/serverso we don't have to figure out an OpenTelemetry deployment for it (again, this image is not recommended for production use so I don't think we need to introduce advanced capabilities like OpenTelemetry out-of-the-box for it (there is some precedent for this - cAdvisor, for example, is not included insourcegraph/server). Users can still configure an exporter withOTEL_EXPORTER_OTLP_ENDPOINT.Docs indicating it is not recommended for production use:
Test plan
CI passes, main-dry-run: https://buildkite.com/sourcegraph/sourcegraph/builds?branch=main-dry-run/src-server-remove-jaeger