batches: Use Draft instead of WIP in GitLab >= 14.0

[BolajiOlajide]

Closes #41796

Test plan

• Added unit test to assert the functionality change.

[sourcegraph-bot]

Codenotify: Notifying subscribers in CODENOTIFY files for diff d5d563a...2c68dd9.

Notify

File(s)

@eseliger

enterprise/internal/batches/sources/gitlab.go enterprise/internal/batches/sources/gitlab_test.go enterprise/internal/batches/sources/testdata/golden/GitlabSource_LoadChangeset_found internal/extsvc/gitlab/client.go internal/extsvc/gitlab/merge_requests.go internal/extsvc/gitlab/merge_requests_test.go internal/extsvc/gitlab/mock.go internal/extsvc/gitlab/version.go internal/extsvc/gitlab/webhooks/merge_requests.go internal/extsvc/versions/mock.go internal/extsvc/versions/store.go internal/extsvc/versions/sync.go internal/extsvc/versions/sync_test.go

[LawnGnome]

What's here LGTM, but I am concerned about the way we're determining the GitLab version in GitLabSource, as described below in an inline comment.

I saw that in an earlier version of this PR we actually invoked GetVersion on the code host — was there a reason we dropped that? (sorry, I somehow missed Erik's post above)

One alternative idea here is that we do actually know what external service(s) are being queried when the version map is being built, so we could extend Version to also include some sort of identifier we can use to get a specific code host's version without calling GetVersion, and then have a fallback to do that on sites that are mid-upgrade and don't have the new field(s) yet in Redis.

Thoughts?

[eseliger]

One alternative idea here is that we do actually know what external service(s) are being queried when the version map is being built, so we could extend Version to also include some sort of identifier we can use to get a specific code host's version without calling GetVersion, and then have a fallback to do that on sites that are mid-upgrade and don't have the new field(s) yet in Redis.

I like that!

[LawnGnome]

Awesome, thanks for taking the time to make the version detection work on a per-external service basis. LGTM!

[eseliger]

LGTM, a few last questions.