This repository was archived by the owner on Sep 30, 2024. It is now read-only.
web: fix <Menu /> in Safari 16 by preventing item blur event from bubbling#42779
Merged
courier-new merged 2 commits intomainfrom Oct 11, 2022
Merged
web: fix <Menu /> in Safari 16 by preventing item blur event from bubbling#42779courier-new merged 2 commits intomainfrom
<Menu /> in Safari 16 by preventing item blur event from bubbling#42779courier-new merged 2 commits intomainfrom
Conversation
courier-new
added
bug
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff 66c77c4...db7b32a.
|
lrhacker
approved these changes
Oct 10, 2022
Contributor
lrhacker
left a comment
lrhacker
left a comment
There was a problem hiding this comment.
Working as expected for me in Safari (and still in Chrome!). Thank you!! ❤️
Contributor
Author
|
Oops I should have put this on |
vovakulikov
approved these changes
Oct 10, 2022
Contributor
vovakulikov
left a comment
vovakulikov
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this and for filing issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As observed in Slack, menus that rely on the
<Menu />family of Wildcard components are broken in Safari 16 due to multiple blur events firing when the menu first opens and focus is transferred to the menu popover itself. The behavior has so far exclusively been observed in Safari 16.0 and 16.1. There is evidence that it may be fixed by 16.4, based on the currently available technology preview.Tested both with keyboard navigation and mouse navigation in Safari 16, Chrome, and Firefox.
Screen.Recording.2022-10-10.at.2.32.39.PM.mov
Screen.Recording.2022-10-10.at.2.33.24.PM.mov
I have filed the follow-up ticket https://github.com/sourcegraph/sourcegraph/issues/42780 to revisit after Safari 16.4 is released.
Test plan
Fix was manually tested, see recordings above.
App preview:
Check out the client app preview documentation to learn more.