Show all possible external connections in Account security. Only allo…

[pjlast]

Solves #38195 and then some

Display all possible external service connections in user's Account Security page. Had to rework a lot of functions, because a lot of them assumed there would only be one provider per type, however, you can have multiple hosts of the same type. So now, instead, we use the auth provider's Service ID (the base URL) as the unique identifier, and we display config errors appropriately when more than one that uses the same URL is used. This is long overdue, as it would have caused undefined behaviour in some parts of the code anyways, when random auth providers are selected.

Further more, I made it so that the user's "Change Password" fields are visible even if they have external accounts, because signing in with a username and password is still valid.

Test plan

Updated unit tests

[sg-e2e-regression-test-bob]

Bundle size report 📦

Initial size	Total size	Async size	Modules
0.00% (0.00 kb)	0.00% (+0.14 kb)	0.00% (+0.14 kb)	0.00% (0)

Look at the Statoscope report for a full comparison between the commits 447af6c and 288371b or learn more.

Open explanation

• Initial size is the size of the initial bundle (the one that is loaded when you open the page)
• Total size is the size of the initial bundle + all the async loaded chunks
• Async size is the size of all the async loaded chunks
• Modules is the number of modules in the initial bundle

[kopancek]

Looks great, small improvements suggested.

[kopancek]

Suggested change

	// auth providers by service type
	// auth providers by serviceID

[kopancek]

I would be more specific here and specify the action in the header, similar as we do in the button at the end of the form.

Suggested change

	<H3 className="mb-3">Password</H3>
	<Container>
	<Form onSubmit={handleSubmit}>
	<H3 className="mb-3">{props.user.builtinAuth ? 'Update ' : 'Create '}Password</H3>
	<Container>
	<Form onSubmit={handleSubmit}>

I would also add a description to this section, because on the screenshot it looks weird. E.g. something like (to be confirmed by @ryphil or someone with better language skills than me):

<p>Create a password for this user account on the <a href="docs">built-in username/password authentication.</a> This will allow the current user to login with username `{user.username}` and password in the future.</p>

And a similar one for the password change:

<p>Change password for this user account on the <a href="docs">built-in username/password authentication.</a></p>

Otherwise users might be confused as to which password they are going to create/change.

[kopancek]

Much better 👍

[sourcegraph-bot]

Codenotify: Notifying subscribers in CODENOTIFY files for diff 288371b...447af6c.

Notify	File(s)
@unknwon	enterprise/cmd/frontend/internal/auth/githuboauth/config.go enterprise/cmd/frontend/internal/auth/githuboauth/config_test.go enterprise/cmd/frontend/internal/auth/gitlaboauth/config.go enterprise/cmd/frontend/internal/auth/gitlaboauth/config_test.go

[unknwon]

Did not look very close, thanks for fixing this!

[unknwon]

nit

Suggested change

	problems = append(problems, conf.NewSiteProblems(fmt.Sprintf("cannot have more than one auth provider with url '%s', only the first one will be used", provider.ServiceID))...)
	problems = append(problems, conf.NewSiteProblems(fmt.Sprintf(`Cannot have more than one auth provider with url %q, only the first one will be used`, provider.ServiceID))...)

[unknwon]

Ditto on nit

[mrnugget]

Big QoL improvement!