insights: remove dirty queries resolver and store logic

[leonore]

closes #44093

opened https://github.com/sourcegraph/sourcegraph/issues/44415

Test plan

Ran existing unit tests and created an insight

[sourcegraph-bot]

Codenotify: Notifying subscribers in CODENOTIFY files for diff 43b76aa...fbff5e8.

Notify

File(s)

@sourcegraph/code-insights-backend

cmd/frontend/graphqlbackend/insights.go enterprise/internal/insights/resolvers/dynamic_insight_series_resolver.go enterprise/internal/insights/resolvers/insight_dirty_query_resolver.go enterprise/internal/insights/resolvers/insight_series_resolver.go enterprise/internal/insights/store/insight_store.go enterprise/internal/insights/store/insight_store_test.go enterprise/internal/insights/store/mocks_temp.go enterprise/internal/insights/store/testdata/TestDirtyQueriesAggregated/write_and_read_back.golden enterprise/internal/insights/types/types.go

[sg-e2e-regression-test-bob]

Bundle size report 📦

Initial size	Total size	Async size	Modules
0.00% (0.00 kb)	0.00% (0.00 kb)	0.00% (0.00 kb)	0.00% (0)

Look at the Statoscope report for a full comparison between the commits fbff5e8 and 43b76aa or learn more.

Open explanation

• Initial size is the size of the initial bundle (the one that is loaded when you open the page)
• Total size is the size of the initial bundle + all the async loaded chunks
• Async size is the size of all the async loaded chunks
• Modules is the number of modules in the initial bundle

[coury-clark]

Since this is a breaking change in the API we will need to include a changelog entry and try to scrub any references, for example here

Code changes look good, just need to make sure we aren't breaking something for someone here.

[leonore]

Since this is a breaking change in the API we will need to include a changelog entry and try to scrub any references, for example here

Code changes look good, just need to make sure we aren't breaking something for someone here.

thanks for catching! I ran a search and I think I've got it all. have a look at the doc changes
https://sourcegraph.sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24%40leo/remove-dirty-queries+dirty+quer+or+dirty+metadata+or+dirtymeta&patternType=standard&sm=0&groupBy=path