Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

show repo corruption events#46004

Merged
burmudar merged 13 commits intomainfrom
wb/repo/corruption-ui
Jan 9, 2023
Merged

show repo corruption events#46004
burmudar merged 13 commits intomainfrom
wb/repo/corruption-ui

Conversation

@burmudar
Copy link
Contributor

@burmudar burmudar commented Dec 29, 2022 •
edited
Loading

  • Shows alert if a repo is currently corrupted
  • Adds a section in the repo mirror info page which shows all repo
    corruption events that have been detected

Alert admin that one of the repos is corrupt

Screenshot 2023-01-04 at 14 16 33

Page with Corruption entries

Screenshot 2023-01-09 at 11 00 23

Page without Corruption entries

Screenshot 2023-01-09 at 11 00 54

Page where repo is currently corrupt

Screenshot 2023-01-09 at 11 31 43

Outstanding

  • Unit tests / integration tests 🤔

Test plan

Manual testing

@cla-bot cla-bot bot added the cla-signed label Dec 29, 2022
This was referenced Dec 29, 2022
Merged
Merged
@burmudar Graphite App
Copy link
Contributor Author

burmudar commented Dec 29, 2022 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@sg-e2e-regression-test-bob
Copy link

sg-e2e-regression-test-bob commented Dec 29, 2022 •
edited
Loading

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.02% (+3.37 kb) 0.03% (+3.37 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits c9fb427 and 19bb235 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from b59fde0 to a914b43 Compare December 30, 2022 10:07
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from 2fd27f4 to 3de99f0 Compare December 30, 2022 10:07
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from a914b43 to 8b3311f Compare December 30, 2022 11:34
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from 3de99f0 to cd79873 Compare December 30, 2022 11:34
@burmudar burmudar mentioned this pull request Dec 30, 2022
Merged
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 8b3311f to 05543ec Compare December 30, 2022 11:42
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from cd79873 to 66d3b37 Compare December 30, 2022 11:43
burmudar
burmudar commented Dec 30, 2022
View reviewed changes
@burmudar burmudar self-assigned this Dec 30, 2022
@burmudar burmudar marked this pull request as ready for review December 30, 2022 13:53
mrnugget
mrnugget reviewed Jan 3, 2023
View reviewed changes
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 05543ec to c27488b Compare January 3, 2023 15:03
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from 1f96300 to 7eeff0a Compare January 3, 2023 15:03
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from c27488b to 57ef59f Compare January 3, 2023 20:43
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from 7eeff0a to 3a3f31a Compare January 3, 2023 20:44
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 57ef59f to 24d4d5c Compare January 3, 2023 21:21
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from 3a3f31a to 68c26ae Compare January 3, 2023 21:21
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 24d4d5c to 7c8c0ef Compare January 3, 2023 21:26
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from 68c26ae to 9ee902c Compare January 3, 2023 21:26
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 7c8c0ef to a6d62fb Compare January 3, 2023 21:32
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from 9ee902c to fc9c844 Compare January 3, 2023 21:32
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from c7402b0 to 87bfd9c Compare January 4, 2023 17:17
@rrhyne
Copy link
Contributor

rrhyne commented Jan 4, 2023

Figma file for improvements to the error displays:

https://www.figma.com/file/KXqltfue2B18TWtEvmExF7/Improve-inline-error-messages.?node-id=0%3A1&t=wabSs8TePQgmbtSC-0

unknwon
unknwon approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an authoritative approval, defer to others who's been following along and have the bandwidth for deep reviews.

valerybugakov
valerybugakov approved these changes Jan 9, 2023
View reviewed changes
@burmudar
Copy link
Contributor Author

burmudar commented Jan 9, 2023

Figma file for improvements to the error displays:

https://www.figma.com/file/KXqltfue2B18TWtEvmExF7/Improve-inline-error-messages.?node-id=0%3A1&t=wabSs8TePQgmbtSC-0

@rrhyne I've updated the PR description with full page screenshots. I'm going to merge this and then address the things you've mentioned so far in the Figma doc in seperate PRs!

@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from c001166 to bb35880 Compare January 9, 2023 11:00
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from 0afa51e to 481a236 Compare January 9, 2023 11:00
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from bb35880 to ad45b26 Compare January 9, 2023 13:12
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from 481a236 to d53f2ec Compare January 9, 2023 13:12
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from ad45b26 to 185c8e1 Compare January 9, 2023 14:45
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from d53f2ec to bd31311 Compare January 9, 2023 14:46
@burmudar Graphite App
Copy link
Contributor Author

burmudar commented Jan 9, 2023 •
edited
Loading

⏳ This pull request is set to merge as part of a Graphite merge job
Stack job ID: hSUUYP6wzZj7kdyI1hms.
See details on graphite.dev

burmudar and others added 13 commits January 9, 2023 17:31
@burmudar
add corruptedAt and corruption log to MirrorInfo resolver
919fde2
@burmudar
expose corruptionLogs and corruptedAt on grapql
bcebdec 
* add corruptionAt field to mirrorInfo
* add corruptionLogResolver
* fetch corruption details for settings area
@burmudar @mrnugget
Update cmd/frontend/graphqlbackend/schema.graphql
b0b37c6 
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
@burmudar @mrnugget
Update cmd/frontend/graphqlbackend/schema.graphql
7ea430f 
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
@burmudar
review feedback
6ab63cc 
- corruptedAt -> isCorruptedAt
- make corruptionLogs values not optional
@burmudar
mark fields in array as not optional
aaa0881
@burmudar
repo corruption ui
e701cf6 
* show alert for repo corruption on admin repositories list page
* add repo corruption section to repo mirror page
* Make Button in ActionAction is optional
@burmudar
add links and headings
49c1059
@burmudar
prop fixup
9e00e7a
@burmudar
review feedback and ui improvements
3ebb386 
- use array map ... fuctional style ftw
- use ternary if
- use collapse header to hide corruption log entries if there are none
- use danger instead of warning for notices
@burmudar
Review feedback
3ffddcd 
- use func direclty instead of useCallback
- use SettingsAreaRepositoryFields type instead of any
- consistent use of chevrons
@burmudar
obey eslint
ed324f7
@burmudar @unknwon @valerybugakov
design feedback
c9fb427 
Co-authored-by: Joe Chen <joe@sourcegraph.com>
Co-authored-by: Valery Bugakov <skymk1@gmail.com>
@burmudar burmudar force-pushed the 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver branch from 185c8e1 to aaa0881 Compare January 9, 2023 15:34
@burmudar burmudar force-pushed the wb/repo/corruption-ui branch from bd31311 to c9fb427 Compare January 9, 2023 15:34
Base automatically changed from 12-21-add_corruptedAt_and_corruption_log_to_MirrorInfo_resolver to main January 9, 2023 15:51
@burmudar burmudar merged commit c555601 into main Jan 9, 2023
@burmudar burmudar deleted the wb/repo/corruption-ui branch January 9, 2023 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eseliger eseliger Awaiting requested review from eseliger

3 more reviewers

@mrnugget mrnugget mrnugget approved these changes

@unknwon unknwon unknwon approved these changes

@valerybugakov valerybugakov valerybugakov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@burmudar burmudar

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@burmudar @sg-e2e-regression-test-bob @rrhyne @mrnugget @unknwon @valerybugakov