This repository was archived by the owner on Sep 30, 2024. It is now read-only.
email.templates: make 'text' template optional#46085
Merged
Conversation
bobheadxi
force-pushed
the
email-optional-text
branch
from
7ce4ba7 to
e5f1a59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses https://github.com/k3a/html2text to automatically convert HTML templates to plain text if one is not provided in
email.templatessite configuration, thus making thetextfield optional.Also removes unused template functions for Markdown/HTML conversions - I don't think we should encourage the use of these, and there are no mentions of them anywhere. User-configurable templates are new and unreleased as well, so this isn't a breaking change.
Follow-up to https://github.com/sourcegraph/sourcegraph/pull/45671#discussion_r1054110770.
Part of https://github.com/sourcegraph/customer/issues/1719.
Test plan
Unit tests