This repository was archived by the owner on Sep 30, 2024. It is now read-only.
client: remove deprecated authenticatedUser.email#46183
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
bobheadxi
force-pushed
the
01-05-client_remove_deprecated_authenticatedUser.email
branch
from
e60c2a0 to
6b80bb1
Compare
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 85d7ee6 and 179254b or learn more. Open explanation
|
bobheadxi
force-pushed
the
01-05-client_remove_deprecated_authenticatedUser.email
branch
4 times, most recently
from
fb5a412 to
863f3b3
Compare
Contributor
|
Not notifying subscribers because the number of notifying subscribers (11) has exceeded the threshold (10). |
bobheadxi
force-pushed
the
01-05-client_remove_deprecated_authenticatedUser.email
branch
from
863f3b3 to
c9913ac
Compare
vdavid
approved these changes
Jan 6, 2023
Contributor
vdavid
left a comment
vdavid
left a comment
There was a problem hiding this comment.
LGTM! If the backend is indeed in place then this should work right. Left two very small nits.
vovakulikov
approved these changes
Jan 6, 2023
Co-authored-by: David Veszelovszki <veszelovszki@gmail.com>
Co-authored-by: David Veszelovszki <veszelovszki@gmail.com>
bobheadxi
force-pushed
the
01-05-client_remove_deprecated_authenticatedUser.email
branch
from
470cc9e to
85d7ee6
Compare
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff 7a6dc29...85d7ee6.
|
limitedmage
approved these changes
Jan 6, 2023
Member
Author
|
Percy change seems unrelated 🤔
Can reproduce in S2:
|
bobheadxi
deleted the
01-05-client_remove_deprecated_authenticatedUser.email
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
authenticatedUsers.emailfield is deprecated - the equivalent can now be found withauthenticatedUsers.emails.find(email => email.isPrimary). This gives more details about the email as well, such as whether it is verified or not, which is required to implement verified email checks (e.g. https://github.com/sourcegraph/sourcegraph/pull/46184)https://github.com/sourcegraph/sourcegraph/blob/fb5a412a9c66c4e08a2fb4dab859a765cdedc1ff/cmd/frontend/graphqlbackend/schema.graphql#L5538-L5542
Test plan
Tests pass still
App preview:
Check out the client app preview documentation to learn more.