batches: implement pagination for batch_spec_workspace_steps.output_lines#46335
batches: implement pagination for batch_spec_workspace_steps.output_lines#46335BolajiOlajide merged 30 commits intomainfrom
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff b4a20e9...e854bf3.
|
|
❌ Problem: the label |
a885147 to
5ea5e45
Compare
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits e854bf3 and b4a20e9 or learn more. Open explanation
|
client/web/src/enterprise/batches/batch-spec/execute/workspaces/WorkspaceDetails.tsx
Outdated
Show resolved
Hide resolved
client/web/src/enterprise/batches/batch-spec/execute/workspaces/WorkspaceDetails.tsx
Outdated
Show resolved
Hide resolved
client/web/src/enterprise/batches/batch-spec/execute/workspaces/WorkspaceDetails.tsx
Outdated
Show resolved
Hide resolved
client/web/src/enterprise/batches/batch-spec/execute/backend.ts
Outdated
Show resolved
Hide resolved
enterprise/cmd/frontend/internal/batches/resolvers/batch_spec_workspace_step.go
Show resolved
Hide resolved
enterprise/cmd/frontend/internal/batches/resolvers/batch_spec_workspace_step.go
Outdated
Show resolved
Hide resolved
|
❌ Problem: the label |
5ea5e45 to
692daee
Compare
|
❌ Problem: the label |
| """ | ||
| A list of output lines. | ||
| """ | ||
| nodes: [String!]! |
There was a problem hiding this comment.
That's cool, I've always wondered what a connection of scalar data would look like and how you'd query it. Turns out it's that simple! 😄
client/web/src/enterprise/batches/batch-spec/execute/backend.ts
Outdated
Show resolved
Hide resolved
client/web/src/enterprise/batches/batch-spec/execute/workspaces/WorkspaceDetails.tsx
Outdated
Show resolved
Hide resolved
db60d13 to
65bd492
Compare
eseliger
left a comment
There was a problem hiding this comment.
looks good, I didn't try this out but trust you that you did :)
courier-new
left a comment
There was a problem hiding this comment.
Amazing, thank you so much for the refactor here!!
client/web/src/enterprise/batches/batch-spec/execute/workspaces/WorkspaceDetails.tsx
Show resolved
Hide resolved
afccf7b to
48f3f7c
Compare
Reported here.
Closes #1800
A customer reported that steps in their spec output were truncated. Started debugging by trying this out with
src-cliand inspecting the log output to confirm if the output was truncated fromsrc-cli; it wasn't.I then proceeded to debug via SSBC route and discovered we stored the complete output in
batch_spec_workspace_execution_jobs.execution_logsand found out the resolver for BatchSpecWorkspace steps was paginated and this meant that when using the${{ previous_step.stdout }}directive one wouldn't get the complete output from the previous steps and the output displayed was truncated.The initial value for slicing the output lines was 500, I'm not 100% certain why that limit was placed but this PR removes the limit so we can get all lines in every step and also display the complete logs for users.
Test plan
Tested with a sample batch spec
Confirmed all output lines are displayed.
Loom