batches: use user name/e-mail with unauthored batch specs#46385
batches: use user name/e-mail with unauthored batch specs#46385
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 4807df1...706182c.
|
|
Codenotify: Notifying subscribers in OWNERS files for diff 4807df1...706182c.
|
courier-new
left a comment
There was a problem hiding this comment.
Looks good to me, but could we trigger the executor e2e tests for this PR to double-check before we merge?
|
@courier-new how can i trigger the executor e2e tests? |
|
❌ Problem: the label |
|
From your branch locally you can run |
|
nice, thanks! looks like its good beside security scans |
courier-new
left a comment
There was a problem hiding this comment.
Awesome thanks! I'll approve to unblock, but I also think there's no rush on this if you want to wait until after 4.4 cut tomorrow.
|
thank uuu! yes thats what i was thinking, ill just wait |
f645b8e to
706182c
Compare
fixes the E2E test that failed after merge in #43828 and needed to be reverted
Implementing the same fallback behaviour for changeset specs on SSBC that we have on the client side where we try to get the author name and e-mail for commits from the environment if they're not in the batch spec by pulling that from the user's account details and created a sub-package author to do so
Test plan
Tested created a bc in various cases with missing information