Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

insights: add export handler back with bugfix for search context loader#46795

Merged
leonore merged 3 commits intomainfrom
leo/fix-sc-loader
Jan 24, 2023
Merged

insights: add export handler back with bugfix for search context loader#46795
leonore merged 3 commits intomainfrom
leo/fix-sc-loader

Conversation

@leonore
Copy link
Contributor

@leonore leonore commented Jan 23, 2023

revert revert for #46662 and add fix

Test plan

See original PR for full test plan

Observed panic when using a search context with insight on main.
No longer saw panic either on insights page or using the export endpoint after fix

@leonore leonore requested a review from a team January 23, 2023 19:25
@leonore leonore self-assigned this Jan 23, 2023
@cla-bot cla-bot bot added the cla-signed label Jan 23, 2023
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jan 23, 2023

Codenotify: Notifying subscribers in CODENOTIFY files for diff 47025db...48bf3c2.

Notify File(s)
@sourcegraph/code-insights-backend enterprise/internal/insights/httpapi/export.go
enterprise/internal/insights/insights.go
enterprise/internal/insights/resolvers/insight_series_resolver.go
enterprise/internal/insights/resolvers/insight_view_resolvers_test.go
enterprise/internal/insights/store/insight_store.go
enterprise/internal/insights/store/mocks_temp.go
enterprise/internal/insights/store/mocks_test.go
enterprise/internal/insights/store/permissions.go
enterprise/internal/insights/store/search_contexts.go
enterprise/internal/insights/store/store.go
enterprise/internal/insights/store/store_test.go

@leonore leonore changed the title insights: fix bug with search context loader refactor insights: add export handler back with bugfix for search context loader Jan 24, 2023
@leonore leonore merged commit 04e120e into main Jan 24, 2023
@leonore leonore deleted the leo/fix-sc-loader branch January 24, 2023 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants