Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Render GitHub links in more places#47593

Merged
philipp-spiess merged 4 commits intomainfrom
ps/render-gh-links-in-more-places
Feb 15, 2023
Merged

Render GitHub links in more places#47593
philipp-spiess merged 4 commits intomainfrom
ps/render-gh-links-in-more-places

Conversation

@philipp-spiess
Copy link
Contributor

@philipp-spiess philipp-spiess commented Feb 14, 2023

Quick follow-up as people seem to like the GitHub PR reference rendering. We now use the same logic in the commit list on the repo home page and the repo commits page.

Test plan

Screenshot 2023-02-14 at 11 40 40

Screenshot 2023-02-14 at 11 29 04

App preview:

Check out the client app preview documentation to learn more.

@philipp-spiess philipp-spiess requested a review from a team February 14, 2023 10:43
@philipp-spiess philipp-spiess self-assigned this Feb 14, 2023
@cla-bot cla-bot bot added the cla-signed label Feb 14, 2023
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Feb 14, 2023
@philipp-spiess
Copy link
Contributor Author

This also removes the bold rendering of the commit message which I find quite confusing actually (too much bold text on this page):

Screenshot 2023-02-14 at 11 45 35

@sg-e2e-regression-test-bob
Copy link

sg-e2e-regression-test-bob commented Feb 14, 2023

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.01% (+0.98 kb) 0.01% (+0.98 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 9694317 and 265acff or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@github-actions
Copy link
Contributor

Problem: the label i-acknowledge-this-goes-into-the-release is absent.
👉 What to do: we're in the next Sourcegraph release code freeze period. If you are 100% sure your changes should get released or provide no risk to the release, add the label your PR with i-acknowledge-this-goes-into-the-release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants