This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Merged
Conversation
Contributor
|
❌ Problem: the label |
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 3337387...0d53bdb.
|
Contributor
sashaostrikov
left a comment
There was a problem hiding this comment.
Let's remove some logs and make some log messages more explicit.
Apart from that LGTM! 👍🏻
sashaostrikov
approved these changes
Feb 17, 2023
Contributor
sashaostrikov
left a comment
There was a problem hiding this comment.
Two small fixes and we're good! 👍
kopancek
approved these changes
Feb 17, 2023
0xnmn
referenced
this pull request
Feb 17, 2023
In response to: https://github.com/sourcegraph/sourcegraph/pull/47783#discussion_r1109445804 ## Test plan ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/sourcegraph/sourcegraph/issues/47160
This PR enables the new perms syncer by default.
Test plan
runSchedule&runSyncshould log