This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: Only send repo criteria at the insight level#49633
Merged
Conversation
… be sent at the series
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 006e8ae and a720267 or learn more. Open explanation
|
vovakulikov
approved these changes
Mar 17, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
Detect & Track insights were sending conflicting insight and series level repo information. This caused the series level data to override the insight level. The series level was not including the repo search and it was being mistaken for an "all repos" insight. resolves https://github.com/sourcegraph/sourcegraph/issues/49631 (cherry picked from commit 7d9e8d5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect & Track insights were sending conflicting insight and series level repo information. This caused the series level data to override the insight level. The series level was not including the repo search and it was being mistaken for an "all repos" insight.
resolves https://github.com/sourcegraph/sourcegraph/issues/49631
Test plan
Create a detect & track insight with repos specified as a repo search.
After creation go to edit to view insight ensure the repo search is still specified.
Verify insight only contains data from expected repos.
App preview:
Check out the client app preview documentation to learn more.