Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

codeintel: Fix background job context auth#51591

Merged
efritz merged 4 commits intomainfrom
ef/internal-background
May 9, 2023
Merged

codeintel: Fix background job context auth#51591
efritz merged 4 commits intomainfrom
ef/internal-background

Conversation

@efritz
Copy link
Contributor

@efritz efritz commented May 8, 2023

Ensure all code intel background jobs run with an internal context. All repos should be visible to the periodic jobs that synchronize, reconcile, and process data. User-level visibility is always considered at retrieval time.

Test plan

Tested locally.

@efritz efritz added team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/language-platform labels May 8, 2023
@efritz efritz requested review from Strum355 and cesrjimenez May 8, 2023 21:39
@efritz efritz self-assigned this May 8, 2023
@cla-bot cla-bot bot added the cla-signed label May 8, 2023
@efritz efritz force-pushed the ef/internal-background branch from 361b8cc to 71e7c83 Compare May 8, 2023 21:40
@efritz efritz force-pushed the ef/internal-background branch 2 times, most recently from 0da0676 to c4ecf9c Compare May 8, 2023 21:42
@efritz efritz force-pushed the ef/internal-background branch from c4ecf9c to 1db506e Compare May 8, 2023 21:43
@efritz efritz marked this pull request as ready for review May 8, 2023 22:56
@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 5284454...c19e350.

Notify File(s)
@Strum355 enterprise/internal/codeintel/autoindexing/internal/background/scheduler/BUILD.bazel
enterprise/internal/codeintel/autoindexing/internal/background/scheduler/job_scheduler.go
enterprise/internal/codeintel/policies/internal/background/repository_matcher/BUILD.bazel
enterprise/internal/codeintel/policies/internal/background/repository_matcher/job.go
enterprise/internal/codeintel/sentinel/internal/background/downloader/BUILD.bazel
enterprise/internal/codeintel/sentinel/internal/background/downloader/job.go
enterprise/internal/codeintel/sentinel/internal/background/matcher/BUILD.bazel
enterprise/internal/codeintel/sentinel/internal/background/matcher/job.go
enterprise/internal/codeintel/shared/background/BUILD.bazel
enterprise/internal/codeintel/shared/background/janitor_job.go
enterprise/internal/codeintel/shared/background/pipeline_job.go
enterprise/internal/codeintel/uploads/internal/background/backfiller/BUILD.bazel
enterprise/internal/codeintel/uploads/internal/background/backfiller/job_backfill.go
enterprise/internal/codeintel/uploads/internal/background/commitgraph/BUILD.bazel
enterprise/internal/codeintel/uploads/internal/background/commitgraph/job_commitgraph.go
enterprise/internal/codeintel/uploads/internal/background/expirer/BUILD.bazel
enterprise/internal/codeintel/uploads/internal/background/expirer/job_expirer.go

@efritz efritz merged commit e068185 into main May 9, 2023
@efritz efritz deleted the ef/internal-background branch May 9, 2023 19:11
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

The backport to 5.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.0 5.0
# Navigate to the new working tree
cd .worktrees/backport-5.0
# Create a new branch
git switch --create backport-51591-to-5.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e0681853b0d6d9b2606a8031186fab969fb57d7d
# Push it to GitHub
git push --set-upstream origin backport-51591-to-5.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.0

Then, create a pull request where the base branch is 5.0 and the compare/head branch is backport-51591-to-5.0.

@github-actions github-actions bot added backports failed-backport-to-5.0 release-blocker Prevents us from releasing: https://about.sourcegraph.com/handbook/engineering/releases labels May 9, 2023
This was referenced May 9, 2023
coury-clark pushed a commit that referenced this pull request May 9, 2023
Backpkort #51591.

## Test plan

N/A.
@camdencheek camdencheek removed the release-blocker Prevents us from releasing: https://about.sourcegraph.com/handbook/engineering/releases label May 16, 2023
efritz added a commit that referenced this pull request May 16, 2023
DaedalusG pushed a commit that referenced this pull request May 16, 2023
Missed policies service when backporting #51591 - #51663.

## Test plan

CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backports cla-signed team/graph Graph Team (previously Code Intel/Language Tools/Language Platform)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants