This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
Contributor
sashaostrikov
left a comment
sashaostrikov
left a comment
There was a problem hiding this comment.
I proposed the other way around for checking that there is already an existing metadata key, PTAL
Contributor
sashaostrikov
left a comment
sashaostrikov
left a comment
There was a problem hiding this comment.
PTAL at my comment, I guess I caused some confusion with my last review, sorry!
kopancek
suggested changes
May 18, 2023
This reverts commit 2bcec90e3a0504a2ef38489b8d356508157e064d.
erzhtor
force-pushed
the
erzhtor/add-repo-meta-create-update-user-friendly-error-messages
branch
from
2bcec90 to
e47b030
Compare
toolmantim
approved these changes
May 18, 2023
Contributor
toolmantim
left a comment
toolmantim
left a comment
There was a problem hiding this comment.
Much nicer!! Minor suggestion is to either remove "Repo", or use the full word "Repository" at the beginning and remove "for the given repository" at the end
Co-authored-by: Tim Lucas <t@toolmantim.com>
Co-authored-by: Tim Lucas <t@toolmantim.com>
camdencheek
approved these changes
May 18, 2023
Co-authored-by: Camden Cheek <camden@ccheek.com>
(chore): add scanKVP and scanKVPs reusable helper functions
Contributor
Author
|
@kopancek, looks like I can't merge PR unless you stamp it? |
kopancek
approved these changes
May 18, 2023
erzhtor
deleted the
erzhtor/add-repo-meta-create-update-user-friendly-error-messages
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/sourcegraph/pr-faqs/issues/96.
Test plan
sg startrepository-metadatafeature flagScreenshots
src repos update-metadatacommand