This repository was archived by the owner on Sep 30, 2024. It is now read-only.
ui: Use CIDs for visiting perforce files from changelist view page#53608
Merged
indradhanush merged 3 commits intomainfrom Jun 19, 2023
Merged
ui: Use CIDs for visiting perforce files from changelist view page#53608indradhanush merged 3 commits intomainfrom
indradhanush merged 3 commits intomainfrom
Conversation
indradhanush
added
perforce
perforce-changelists
This was referenced Jun 16, 2023
4 tasks
Contributor
peterguy
approved these changes
Jun 16, 2023
Contributor
peterguy
left a comment
peterguy
left a comment
There was a problem hiding this comment.
worked great locally; LGTM
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 6ec4eb4...0ce82f0.
|
indradhanush
force-pushed
the
ig/changelist-permalinks-on-files
branch
from
59989c6 to
7591abc
Compare
Contributor
Author
|
Rebased off main and dropped backend commits from this PR. |
indradhanush
force-pushed
the
ig/changelist-permalinks-on-files
branch
from
7591abc to
0ce82f0
Compare
indradhanush
added a commit
that referenced
this pull request
Jun 21, 2023
coury-clark
pushed a commit
that referenced
this pull request
Jun 21, 2023
…st view page (#53668) Stacked on #53605. Part of #40330. ## Test plan 🎥 https://www.loom.com/share/a516e86ffc4341f7a7bfd83c1808c7bd?sid=d6d1d5fe-5842-458e-8078-4fb3d4e9d0c1 <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> <br> Backport 65345a7 from #53608 Co-authored-by: Indradhanush Gupta <indradhanush.gupta@gmail.com>
ErikaRS
pushed a commit
that referenced
this pull request
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #53605.
Part of #40330.
Test plan
🎥 https://www.loom.com/share/a516e86ffc4341f7a7bfd83c1808c7bd?sid=d6d1d5fe-5842-458e-8078-4fb3d4e9d0c1