This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix siteadmin check in users connection endpoint#55322
Merged
Conversation
burmudar
approved these changes
Jul 26, 2023
sashaostrikov
approved these changes
Jul 26, 2023
Contributor
sashaostrikov
left a comment
sashaostrikov
left a comment
There was a problem hiding this comment.
Thanks for the fix! 🙏
eseliger
approved these changes
Jul 26, 2023
| log.Object("repo", | ||
| log.String("user", user.Username))), | ||
| }) | ||
| l = append(l, NewUserResolver(ctx, r.db, user)) |
Member
There was a problem hiding this comment.
I think if using the user resolver directly is not valid, we should not export it either.
This PR is a good fix and can land quickly, but I would love to see us follow up with unexporting the type :)
Contributor
Author
There was a problem hiding this comment.
Its in the same package either way so it wouldnt have helped for this case, but agreed
github-actions bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
https://github.com/sourcegraph/sourcegraph/pull/50228 introduced a new `actor` field on `UserResolver` to reduce amount of user lookups required. This wasnt being set in all places (or it was assumed that all instantiation of `UserResolver` was through `NewUserResolver`), resulting in actor being unset for this codepath, and hence nil panic when any of the fields that would reference the new field. Not sure who to request PR review from, so feel free to stamp ## Test plan Added unit test coverage and manual testing in API console (cherry picked from commit c3bfec8)
coury-clark
pushed a commit
that referenced
this pull request
Jul 26, 2023
https://github.com/sourcegraph/sourcegraph/pull/50228 introduced a new `actor` field on `UserResolver` to reduce amount of user lookups required. This wasnt being set in all places (or it was assumed that all instantiation of `UserResolver` was through `NewUserResolver`), resulting in actor being unset for this codepath, and hence nil panic when any of the fields that would reference the new field. Not sure who to request PR review from, so feel free to stamp ## Test plan Added unit test coverage and manual testing in API console <br> Backport c3bfec8 from #55322 Co-authored-by: Noah S-C <noah@sourcegraph.com>
MaedahBatool
pushed a commit
that referenced
this pull request
Jul 28, 2023
https://github.com/sourcegraph/sourcegraph/pull/50228 introduced a new `actor` field on `UserResolver` to reduce amount of user lookups required. This wasnt being set in all places (or it was assumed that all instantiation of `UserResolver` was through `NewUserResolver`), resulting in actor being unset for this codepath, and hence nil panic when any of the fields that would reference the new field. Not sure who to request PR review from, so feel free to stamp ## Test plan Added unit test coverage and manual testing in API console
davejrt
pushed a commit
that referenced
this pull request
Aug 9, 2023
https://github.com/sourcegraph/sourcegraph/pull/50228 introduced a new `actor` field on `UserResolver` to reduce amount of user lookups required. This wasnt being set in all places (or it was assumed that all instantiation of `UserResolver` was through `NewUserResolver`), resulting in actor being unset for this codepath, and hence nil panic when any of the fields that would reference the new field. Not sure who to request PR review from, so feel free to stamp ## Test plan Added unit test coverage and manual testing in API console
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/sourcegraph/sourcegraph/pull/50228 introduced a new
actorfield onUserResolverto reduce amount of user lookups required.This wasnt being set in all places (or it was assumed that all instantiation of
UserResolverwas throughNewUserResolver), resulting in actor being unset for this codepath, and hence nil panic when any of the fields that would reference the new field.Not sure who to request PR review from, so feel free to stamp
Test plan
Added unit test coverage and manual testing in API console