This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Merged
Conversation
willdollman
approved these changes
Aug 7, 2023
burmudar
reviewed
Aug 7, 2023
burmudar
reviewed
Aug 7, 2023
Contributor
burmudar
left a comment
burmudar
left a comment
There was a problem hiding this comment.
2.7.3 got released over the weekend and the official recommendation is to use that rather than 2.7.2
Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com>
burmudar
reviewed
Aug 7, 2023
burmudar
approved these changes
Aug 7, 2023
Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com>
evict
changed the title
Contributor
|
Waiting on caddy 2.7.3 docker images to be released |
Contributor
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
* dep: bump up caddy version * update changelog * dep: use caddy 2.7.3 Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com> * dep: use caddy 2.7.3 Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com> --------- Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com> Co-authored-by: Will Dollman <will.dollman@sourcegraph.com> (cherry picked from commit d13bc81)
sanderginn
pushed a commit
that referenced
this pull request
Aug 16, 2023
dep: bump up caddy version to 2.7.3 (#55606) * dep: bump up caddy version * update changelog * dep: use caddy 2.7.3 Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com> * dep: use caddy 2.7.3 Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com> --------- Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com> Co-authored-by: Will Dollman <will.dollman@sourcegraph.com> (cherry picked from commit d13bc81) Co-authored-by: Vincent <evict@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure we use a later version of Caddy, with less vulnerabilities. We move from version 2.4.5 to 2.7.3.
Test plan
Tested the changes locally using
sg start, confirms it's still serving SSL with 2.7.3.