This repository was archived by the owner on Sep 30, 2024. It is now read-only.
search: disable structural search by default#57584
Merged
stefanhengl merged 9 commits intomainfrom Jan 9, 2024
Merged
Conversation
This disables structural search by default. Users who haven't explicitly enabled it can turn it back on by setting `experimentalFeatures.structuralSearch: "enabled"` in site-admin settings. This does not mean the feature is deprecated. We are simply switching the default. Test plan: CI
stefanhengl
force-pushed
the
sh/disable-structural-search
branch
from
6ad86c6 to
57f2a83
Compare
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 79486a0...9705b7e.
|
mrnugget
approved these changes
Oct 13, 2023
Member
|
We should get approval from others before this ends up in a release. Additionally we need a plan for environments we do continuous deployments. Even though this is just disabling by default, given there is product buy in for this feature (as low maintained as it is), this can be seen as a big change. |
Contributor
keegancsmith
approved these changes
Jan 8, 2024
Member
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
Funny that the feature toggle is still under experimental features...
Ship it!
stefanhengl
referenced
this pull request
in sourcegraph/docs
Jan 17, 2024
Relates to https://github.com/sourcegraph/sourcegraph/pull/57584 Structural search will be disabled by default from 5.3 on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables structural search by default. As a consequence the toggle for structural search
[ ]will be hidden in the UI and API calls with a structural search query will fail.Users can re-enable structural search by setting
experimentalFeatures.structuralSearch: "enabled"in site configuration.Note: The feature is not deprecated. We are merely switching the default from "enabled" to "disabled".
Test plan:
updated unit tests: a couple of tests expected structural search to be on by default. I updated the tests to enable structural search explicitly.