Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 23634d9...0faaf3e.
|
chwarwick
left a comment
There was a problem hiding this comment.
See note about model's otherwise I think once you get the test passing it 👍 . Remember to wait for the data pr before merging. Also pings used to require an approved RFC.
de89d4f to
b02484b
Compare
|
Thanks for your review, @chwarwick! Very helpful comments! |
| c := conf.SiteConfig() | ||
| providers := types.CodyProviders{ | ||
| Completions: &types.CodyCompletionProvider{ | ||
| Provider: c.Completions.Provider, |
There was a problem hiding this comment.
Just realized Completions & Embeddings are optional configurations. I think this could or will crash for instances with Cody disabled or ones with the most basic cody.enabled:true setup.
Additionally you should probably use the GetCompletionsConfig and corresponding embeddings one, because it fills in all the defaults.
There was a problem hiding this comment.
Thank you, @chwarwick! Updated code and PR description.
dadlerj
left a comment
There was a problem hiding this comment.
See comments in the thread about the future of collecting this via pings: https://sourcegraph.slack.com/archives/CN4FC7XT4/p1702399336866429?thread_ts=1702377291.476959&cid=CN4FC7XT4
For now, approved!
Co-authored-by: Dan Adler <dadlerj@users.noreply.github.com>
(cherry picked from commit 2ffd9d6)
Adds Cody completions and embeddings providers data to pings.
Provider name is always included. Model name is included only for "sourcegraph" provider.
Closes https://github.com/sourcegraph/sourcegraph/issues/58826
BigQuery pings schema update
{ "cody.enabled": false }"codyProviders": { "Embeddings": null, "Completions": null }GetCompletionsConfigandGetEmbeddingsConfig{ "cody.enabled": true, "completions": { "chatModel": "claude-v1", "completionModel": "claude-instant-v1", "fastChatModel": "claude-instant-1" "provider": "anthropic", "accessToken": "REDACTED" } }"codyProviders": { "Embeddings": { "Model": "openai/text-embedding-ada-002", "Provider": "sourcegraph" }, "Completions": { "Provider": "anthropic", "ChatModel": "", "CompletionModel": "", "FastChatModel": "" } }{ "cody.enabled": true, "embeddings": { "provider": "sourcegraph", "accessToken": "REDACTED" } }"codyProviders": { "Embeddings": { "Model": "openai/text-embedding-ada-002", "Provider": "sourcegraph" }, "Completions": { "Provider": "sourcegraph", "ChatModel": "anthropic/claude-2.0", "CompletionModel": "anthropic/claude-instant-1", "FastChatModel": "anthropic/claude-instant-1" } }Test plan
Preview 🤩
Preview Link