This repository was archived by the owner on Sep 30, 2024. It is now read-only.
blob/codeintel: Fix popover links to include specified revision#60545
Merged
blob/codeintel: Fix popover links to include specified revision#60545
Conversation
BolajiOlajide
approved these changes
Feb 15, 2024
Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com>
varungandhi-src
approved these changes
Feb 15, 2024
Contributor
varungandhi-src
left a comment
varungandhi-src
left a comment
There was a problem hiding this comment.
Verified that this works locally for the example in the linked issue. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60541
The revision from the URL wasn't passed to the codeintel extension.
Test plan
The links in the tooltip shown at
https://sourcegraph.test:3443/github.com/uber-go/cff@239d0216e326c2d061a71c62fbfe7b8bbd4771ef/-/blob/internal/package.go?L85:14&popover=pinned contain the revision from the URL.